Skip to content

chore: remove redundant punctuation - #1434

Merged
alamb merged 2 commits into
apache:mainfrom
Fischer0522:chore/expected
Sep 20, 2024
Merged

alamb merged 2 commits into
apache:mainfrom
Fischer0522:chore/expected

Conversation

@Fischer0522

Copy link
Copy Markdown
Contributor

related to #1433

@git-hulk

git-hulk commented Sep 19, 2024 •

Copy link
Copy Markdown
Member

@Fischer0522 Need to fix test cases as well. You can run cargo test --all-features on your side to check this.

@Fischer0522

Copy link
Copy Markdown
Contributor Author

@Fischer0522 Need to fix test cases as well. You can run cargo test --all-features on your side to check this.

done.

@git-hulk git-hulk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, cc @iffyio

@alamb alamb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Fischer0522 and @git-hulk

@coveralls

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 10936890491

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 15 of 15 (100.0%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.336%

Totals Coverage Status
Change from base Build 10892026190: 0.0%
Covered Lines: 29446
Relevant Lines: 32961

💛 - Coveralls

@Fischer0522

Copy link
Copy Markdown
Contributor Author

Can this pr be merged before next release? we are using sqlparser-rs in our project and this issue makes my leader mildly irritated @alamb

@iffyio iffyio left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alamb
alamb merged commit 71318df into apache:main Sep 20, 2024
@alamb

alamb commented Sep 20, 2024

Copy link
Copy Markdown
Contributor

Can this pr be merged before next release? we are using sqlparser-rs in our project and this issue makes my leader mildly irritated @alamb

Of course! Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants