Repository navigation
Stack overflow in Statement::to_string for deeply nested expresions #984
Description
It seems that Statement::to_string overflows for deep expressions even if the default recursion limit is able to parse the expression without error:
#[test]
fn render_overflow() {
let expr = "SELECT 1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1";
let statements = sqlparser::parser::Parser::parse_sql(&GenericDialect {}, expr).unwrap();
println!("Was able to parse");
assert_eq!(&statements[0].to_string(), expr);
}Outputs
Was able to parse
thread 'normalize::span::description::sql::parser::render_overflow' has overflowed its stack
fatal runtime error: stack overflow
Version: 0.37.0
Activity
alamb commentedon Oct 2, 2023
Thank you @jjbayer -- this would indeed be nice to fix.
I do suspect this would be less likely to happen in release builds
[-]Stack overflow in `Statement::to_string`[/-][+]Stack overflow in `Statement::to_string` for deeply nested expresions[/+]blaginin commentedon Nov 14, 2024
@2010YOUY01 made a great point about stack overflow today!
@alamb, are you OK if I bring
#[recursive]here as well? cc @peter-tothpeter-toth commentedon Nov 14, 2024
@blaginin, apache/datafusion#9375 (comment) / apache/datafusion#13376 (comment) (Issue 1) was also an sqlparser issue, that probably can be fixed with
#[recursive]. I wonder if you could fix that as well?