Repository navigation
Fail to parse - "select * from (table_name)" #154
Description
I think it's fail here - https://github.com/andygrove/sqlparser-rs/blob/master/src/parser.rs#L1797
because the code assume that inside the Parenthesis should be TableFactor::Derived or TableFactor::NestedJoin, but it's not take in account it's could be TableFactor::Table
Activity
nickolay commentedon Mar 31, 2020
from (table_name)is not actually valid SQL. Note that<table primary>in the ANSI SQL grammar does not allow parentheses around<table or query name>. A quick test shows that at least MS SQL Server follows the spec here. What database are you working with?eyalleshem commentedon Mar 31, 2020
Thanks for the fast response :)
I tested against snowflake ..
Is that something that could be solve by building a dialect ?
nickolay commentedon Mar 31, 2020
Theoretically, yes. Practically in the current implementation the selected dialect only affects the tokenizer, and the parser unconditionally tries to parse some non-standard constructs.
eyalleshem commentedon Mar 31, 2020
So a code that support such syntax could be accepted?
nickolay commentedon Mar 31, 2020
I guess so, if it's going to be a simple change, that doesn't introduce problems parsing the standard syntax (this specific bit of the parser is quite complex as it is). @benesch what do you think?
eyalleshem commentedon Mar 31, 2020
well - i tried :)
nickolay commentedon Apr 21, 2020
PR #155 is now merged, closing this. Thanks!
[snowflake] Support specifying an alias after `FROM (table_factor)`