Repository navigation
Migrate Iceberg leaf nodes to the DataSource trait - #50
Merged
Merged
Conversation
gabotechs
changed the title
NoahKusaba
approved these changes
Oct 7, 2026
alamb
approved these changes
Oct 9, 2026
alamb
left a comment
alamb
left a comment
Contributor
There was a problem hiding this comment.
Thank you @gabotechs and @NoahKusaba
13 of 38 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates leaf node implementations to the
DataSourcetrait, rather than them being rawExecutionPlans.From DataFusion docs:
The Iceberg leaf nodes, at the end of the day, are the ones in charge of scanning files, so this sets the right foundation for them to implement a consistent API with what other file-scanning leaf nodes implement (like the
FileScanConfigupstream in charge of reading Parquet files).