Repository navigation
perf: Improve performance of normalize_nan - #2999
Merged
Merged
Conversation
andygrove
marked this pull request as ready for review
December 27, 2025 17:08
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2999 +/- ##
============================================
+ Coverage 56.12% 59.58% +3.46%
- Complexity 976 1377 +401
============================================
Files 119 167 +48
Lines 11743 15493 +3750
Branches 2251 2569 +318
============================================
+ Hits 6591 9232 +2641
- Misses 4012 4962 +950
- Partials 1140 1299 +159 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Comet TPC-H Benchmark ResultsCommit: Query Times
Total Time: 305.71 seconds Automated benchmark run by dfbench |
comphead
reviewed
Jan 2, 2026
| Ok(ColumnarValue::Array(Arc::new(new_array))) | ||
| let input = as_primitive_array::<Float32Type>(&array); | ||
| // Use unary which operates directly on values buffer without intermediate allocation | ||
| let result: Float32Array = unary(input, normalize_float); |
Contributor
There was a problem hiding this comment.
👍 unary is fast but it requires the operation to be infallible and this is the case here.
Member
Author
|
Thanks for the review @comphead |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
Avoid some allocations.
What changes are included in this PR?
How are these changes tested?