Repository navigation
doc: Add Quickstart Comet doc section - #125
Merged
Merged
Conversation
sunchao
changed the title
sunchao
reviewed
Feb 27, 2024
| ``` | ||
| spark-shell --jars spark/target/comet-spark-spark3.4_2.12-0.1.0-SNAPSHOT.jar \ | ||
| --conf spark.sql.extensions=org.apache.comet.CometSparkSessionExtensions \ | ||
| --conf spark.comet.enabled=true \ |
Member
There was a problem hiding this comment.
we need a separate section to guide through shuffle related settings, but can be done later.
sunchao
approved these changes
Feb 28, 2024
Member
|
Merged, thanks! |
viirya
reviewed
Feb 28, 2024
| - INFO message shows the native Comet library has been initialized. | ||
| - The query plan reflects Comet operators being used for this query instead of Spark ones | ||
| ```scala | ||
| scala> spark.read.parquet("/tmp/test").createOrReplaceTempView("t1"); spark.sql("select * from t1 where a > 5").explain |
Member
There was a problem hiding this comment.
It should be nicer to read if newline is added.
scala> spark.read.parquet("/tmp/test").createOrReplaceTempView("t1")
scala> spark.sql("select * from t1 where a > 5").explain
viirya
reviewed
Feb 28, 2024
| == Physical Plan == | ||
| *(1) ColumnarToRow | ||
| +- CometFilter [a#14], (isnotnull(a#14) AND (a#14 > 5)) | ||
| +- CometScan parquet [a#14] Batched: true, DataFilters: [isnotnull(a#14), (a#14 > 5)], Format: CometParquet, Location: InMemoryFileIndex(1 paths)[file:/tmp/test], PartitionFilters: [], PushedFilters: [IsNotNull(a), GreaterThan(a,5)], ReadSchema: struct<a:int> |
Member
There was a problem hiding this comment.
And the explained plan string too. Right now it is a long string which is hard to read.
Contributor
Author
There was a problem hiding this comment.
I'll break it into some newlines for easier reading
This was referenced Feb 28, 2024
Closed
schenksj
added a commit
to schenksj/datafusion-comet
that referenced
this pull request
May 20, 2026
…test
Patch `DeltaSuite "query with predicates should skip partitions"` to
also recognise `CometDeltaNativeScanExec` in its
`executedPlan.collect { case f: FileSourceScanExec => f }`. Comet's
planner replaces the underlying `FileSourceScanExec` with the contrib's
native exec; without this hunk the collect returns an empty list and
the test fails at `assert(fileScans.size == 1)`.
The contrib's exec exposes the same `numFiles` metric (aliased to
`total_files` over the post-prunePartitions task list), so once the
test sees the exec the existing assertion on `numFiles == 1` validates
that driver-side partition pruning is actually filtering AddFiles.
Closes tasks apache#124 (partition pushdown validated) and apache#125 (data-stats
pushdown validated via `DataSkippingDeltaV1Suite "loading data from
Delta to parquet should skip data"`).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #57 .
Rationale for this change
What changes are included in this PR?
Quickstart Comet doc section
How are these changes tested?