Skip to content

Improve performance of update metrics #1328

Closed

Description

@wForget

What is the problem the feature request solves?

When I profiled tpcds q64, I found that update_metrics took 8.9 % of task time.

Image

Describe the potential solution

I propose the following improvements to optimize update metrics:

  • Define a NativeMetricNode proto type to pass all metric nodes at once to avoid iterative jni calls.
  • Call update metrics when releasing plan to reduce the number of calls.

Additional context

No response

Activity

  1. wForget commented on Jan 23, 2025

    @wForget
    MemberAuthor

    Similar to #391 (comment)

  2. added this to the 0.6.0 milestone on Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions