Skip to content

[EPIC] Spark SQL test failures when Comet JVM shuffle is used #1254

Closed

Description

@andygrove

What is the problem the feature request solves?

#1209 enabled accelerating more queries with Comet but also exposed some new bugs so a COMET_SHUFFLE_FALLBACK_TO_COLUMNAR config was added as a temporary workaround to avoid Spark SQL tests failing.

We should remove this config once the bugs are fixed so that we test more of the Spark SQL queries with Comet shuffle.

Issues:

Failing tests:

core1

core2

core3

  • SPARK-32649: Optimize BHJ/SHJ inner/semi join with empty hashed relation *** FAILED *** (145 milliseconds)
    • assertion fails on number of shuffled hash joins in plan
  • SPARK-38237: require all cluster keys for child required distribution for window query *** FAILED *** (183 milliseconds)
    • shuffleByRequirement was false Can't find desired shuffle node from the query plan [test needs updating]

Describe the potential solution

No response

Additional context

No response

Activity

  1. modified the milestones: 0.5.0, 0.6.0 on Jan 9, 2025
  2. modified the milestones: 0.6.0, 0.7.0, 0.8.0 on Feb 3, 2025
  3. modified the milestones: 0.8.0, 0.9.0 on Apr 17, 2025
  4. changed the title [-]Remove COMET_SHUFFLE_FALLBACK_TO_COLUMNAR config[/-] [+][EPIC] Spark SQL test failures when Comet JVM shuffle is used[/+] on May 30, 2025
  5. coderfender commented on Jun 2, 2025

    @coderfender
    Contributor

    Barring AQE and DPP tets ( addressed in a different PR #1811 ) , I am able to run these tests successfully . Not sure if this is still an issue @andygrove ?

  6. andygrove commented on Jun 3, 2025

    @andygrove
    MemberAuthor

    Barring AQE and DPP tets ( addressed in a different PR #1811 ) , I am able to run these tests successfully . Not sure if this is still an issue @andygrove ?

    The tests are still failing in CI in #1736

  7. andygrove commented on Jun 13, 2025

    @andygrove
    MemberAuthor

    I removed the following from the scope of this issue since they turned out not to be bugs or correctness issues, but valid failures because Comet does not support DPP natively yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions