Skip to content

Delegate to native code for cast_is_supported #1171

Closed

Description

@andygrove

What is the problem the feature request solves?

PR #1169 re-implements the logic for determining which casts are supported by Spark/Comet in native code because it is now needed when reading from ParquetExec.

This means that we have the same code implemented both in Scala and native code.

Describe the potential solution

Perhaps we can have the Scala code call the native code via JNI rather than maintain two copies.

Additional context

No response

Activity

  1. andygrove commented on Jan 8, 2025

    @andygrove
    MemberAuthor

    The native code mentioned above is now specific to parquet-to-spark conversion, so closing this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions