You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We currently have a bunch of TPC-H/TPC-DS test suites including CometTPCDSQuerySuite, CometPlanStabilitySuite, etc. In order to use these, we need to add the golden files generated via Comet first.
Activity
viirya commentedon Feb 12, 2024
This is blocked by #8
sunchao commentedon Feb 12, 2024
Hmm, I thought we just need to generate the files locally?
viirya commentedon Feb 12, 2024
I thought you want run these test suite, e.g.,
CometTPCDSQuerySuite,CometPlanStabilitySuite, on CI?viirya commentedon Feb 12, 2024
Without the CI pipeline, it seems no much sense to include these golden files.
sunchao commentedon Feb 12, 2024
Right, in that sense it is more related to #7. #8 is to run SQL tests in Spark itself.
fix: address all remaining code review items