CASSANDRA-21666 Fix compression dictionary training failing with "insufficient samples" on large-chunk tables - #5131
Closed
smiklosovic wants to merge 2 commits into
Closed
smiklosovic wants to merge 2 commits into
smiklosovic wants to merge 2 commits into
Conversation
yifan-c
reviewed
Sep 8, 2026
| long remainingTarget = Math.min(targetChunkCount - sampleCount, (config.maxTotalSampleSize - totalSampleSize) / info.chunkSize); | ||
| long chunksFromThisSSTable = Math.min((targetChunkCount * info.chunkCount) / totalChunks, remainingTarget); | ||
| long proportionalChunks = (targetChunkCount * info.chunkCount) / totalChunks; | ||
| long chunksFromThisSSTable = Math.min(Math.max(1, proportionalChunks), remainingTarget); |
Contributor
There was a problem hiding this comment.
nit: Since it now greedily picks at least 1 chunk based on the list order, how about shuffling the sstableInfos list to preserve the randomness?
…s" on large-chunk tables
smiklosovic
force-pushed
the
CASSANDRA-21666-6.0
branch
from
September 10, 2026 08:42
8a826f3 to
ce80402
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for sending a pull request! Here are some tips if you're new here:
Commit messages should follow the following format:
The Cassandra Jira