Repository navigation
Support old syntax for DataType parsing - #8541
Merged
Merged
Conversation
github-actions
Bot
added
parquet
alamb
force-pushed
the
alamb/fix_datatype_parsing
branch
from
October 2, 2025 16:25
ce539c6 to
64abb2a
Compare
github-actions
Bot
removed
parquet
alamb
marked this pull request as ready for review
October 2, 2025 17:13
emilk
approved these changes
Oct 2, 2025
emilk
left a comment
emilk
left a comment
Contributor
There was a problem hiding this comment.
Thanks! Should we document that any changes to datatype_parse should be backwards compatible?
etseidl
approved these changes
Oct 2, 2025
Contributor
Author
Yes, thank you for that suggestion I added comments and additional tests for backwards compatibility |
alamb
commented
Oct 3, 2025
| r#"Timestamp(Second, Some("+00:00"))"#, | ||
| Timestamp(Second, Some("+00:00".into())), | ||
| ), | ||
| ("Null", Null), |
Contributor
Author
There was a problem hiding this comment.
these tests now encode all the current round trip cases in an explicit backwards compatiblity mode test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Systems like DataFusion use the string representation of DataType in their public APIs but the type names have changed after
We should retain backwards compatibility with the old type names too
What changes are included in this PR?
Timestamp(Nanosecond, None)andTimestamp(Nanosecond, None)style timestamp specifiersAre these changes tested?
Yes, with new tests
Are there any user-facing changes?
See above