Fix record formatting in 1.58 - #1178
Merged
Merged
Conversation
tustvold
force-pushed
the
stable-output-format
branch
from
January 14, 2022 22:33
76f6d0c to
2069358
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1178 +/- ##
==========================================
+ Coverage 82.59% 82.66% +0.07%
==========================================
Files 173 173
Lines 50919 50902 -17
==========================================
+ Hits 42055 42077 +22
+ Misses 8864 8825 -39 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
houqp
approved these changes
Jan 15, 2022
Contributor
|
Thanks @tustvold |
ovr
pushed a commit
to cube-js/arrow-rs
that referenced
this pull request
Apr 2, 2024
ovr
pushed a commit
to cube-js/arrow-rs
that referenced
this pull request
Apr 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1177
Rationale for this change
Fixes failing tests
What changes are included in this PR?
There appears to have been a change in the debug formatting of floats in 1.58 that causes the debug output to change - in particular it prints in scientific notation where previously it did not. I can't find explicit mention of this in the release notes, but have confirmed it locally.
I've replicated the behavior tested by the tests, but I'm not entirely sure this is exactly what it would have previously output for all cases. The debug outputs are not stable.
Are there any user-facing changes?
No