Skip to content

Improve the performance of "DictionaryValue" row encoding #4712

Closed

Description

@alamb

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

We are consider using the "don't use dictionary interning" in DataFusion for high cardinality columns: apache/datafusion#7200 (comment)

@tustvold mentioned this mode could be made faster

Describe the solution you'd like
Review and optimize Code::DictionaryValues

https://github.com/apache/arrow-rs/blob/b810e8f207bbc70294b01acba4be32153c18a6ab/arrow-row/src/lib.rs#L437C14-L437C14

Perhaps this could be made faster:

Codec::DictionaryValues(converter, _) => {

(I am not sure)

Describe alternatives you've considered
There may not be any way to make this faster, but I wanted to file the ticket as follow on to the meeting

Additional context

Activity

  1. changed the title [-]Improve the format of "DictionaryValue" row encoding[/-] [+]Improve the performance of "DictionaryValue" row encoding[/+] on Aug 17, 2023
  2. alamb commented on Sep 25, 2023

    @alamb
    ContributorAuthor

    For the record, this was fixed b/c we deleted the code that it tracked optimizing 🔥

  3. tustvold commented on Oct 18, 2023

    @tustvold
    Contributor

    label_issue.py automatically added labels {'arrow'} from #4819

  4. tustvold commented on Oct 18, 2023

    @tustvold
    Contributor

    label_issue.py automatically added labels {'arrow-flight'} from #4819

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    arrowChanges to the arrow cratearrow-flightChanges to the arrow-flight crateenhancementNew feature/addition

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions