You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Use IntoIter trait for write_batch/write_mini_batch #43
Over the course of working sets of this data, you'll have the bulk data Vec, the names column in a Vec<&String>, the address column in a Vec<Option>. This puts extra memory pressure on the system, at the minimum we have to allocate a Vec the same size as the bulk data even if we are using references.
What I'm proposing is to use an IntoIter style. This will maintain backward compat as a slice automatically implements IntoIter. Where ColumnWriterImpl#write_batch goes from "values: &[T::T]"to values "values: IntoIter<Item=T::T>". Then you can do things like
Comment from Xavier Lange(xrl) @ 2019-04-09T19:22:29.534+0000:
[~csun] [~sadikovi] what do you think of this potentially breaking change? I need to confirm the backwards compatibility but I think it might still be a useful change.
Comment from Ivan Sadikov(sadikovi) @ 2019-04-09T19:33:52.271+0000:
[~xrl] Yes, sure. I will be happy to review if you open a PR with changes. We can create a new method "write_batch_iter", which implements new API and make "write_batch" to call the new method, since as you pointed out slice implements IntoIter.
changed the title [-][Parquet] Use IntoIter trait for write_batch/write_mini_batch[/-][+]Use IntoIter trait for write_batch/write_mini_batch[/+]on Apr 29, 2021
Activity
alamb commentedon Apr 26, 2021
Comment from Xavier Lange(xrl) @ 2019-04-09T19:22:29.534+0000:
Comment from Ivan Sadikov(sadikovi) @ 2019-04-09T19:33:52.271+0000:
[-][Parquet] Use IntoIter trait for write_batch/write_mini_batch[/-][+]Use IntoIter trait for write_batch/write_mini_batch[/+]tustvold commentedon Aug 11, 2023
Closed by #2045