feat(java/driver/jni): add fluent connection interface - #4452
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces a fluent builder-style API on JniDriver to simplify configuring JNI driver-manager parameters and opening an AdbcDatabase, and updates JNI validation integration tests to exercise the new fluent path.
Changes:
- Add
JniDriver.load()and an innerBuilderwith fluent setters (driver,profile,uri,param) andopen(). - Update SQL Server integration test to also validate the fluent API path.
- Update PostgreSQL integration setup to use the fluent API and clean up unused imports.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| java/driver/jni/src/main/java/org/apache/arrow/adbc/driver/jni/JniDriver.java | Adds a fluent builder API for configuring parameters and opening a JNI-backed database. |
| java/driver/jni-validation/src/test/java/org/apache/arrow/adbc/driver/jni/SqlServerIntegrationTest.java | Adds coverage for opening a DB via the new fluent API. |
| java/driver/jni-validation/src/test/java/org/apache/arrow/adbc/driver/jni/PostgresIntegrationTest.java | Switches test setup to the fluent API and removes now-unused imports. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lidavidm
marked this pull request as ready for review
July 1, 2026 06:16
zeroshade
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.