Skip to content

feat(java/driver/jni): add fluent connection interface - #4452

Merged
lidavidm merged 2 commits into
apache:mainfrom
lidavidm:jni-builder
Jul 2, 2026
Merged

feat(java/driver/jni): add fluent connection interface#4452
lidavidm merged 2 commits into
apache:mainfrom
lidavidm:jni-builder

Conversation

@lidavidm

@lidavidm lidavidm commented Jul 1, 2026

Copy link
Copy Markdown
Member

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces a fluent builder-style API on JniDriver to simplify configuring JNI driver-manager parameters and opening an AdbcDatabase, and updates JNI validation integration tests to exercise the new fluent path.

Changes:

  • Add JniDriver.load() and an inner Builder with fluent setters (driver, profile, uri, param) and open().
  • Update SQL Server integration test to also validate the fluent API path.
  • Update PostgreSQL integration setup to use the fluent API and clean up unused imports.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
java/driver/jni/src/main/java/org/apache/arrow/adbc/driver/jni/JniDriver.java Adds a fluent builder API for configuring parameters and opening a JNI-backed database.
java/driver/jni-validation/src/test/java/org/apache/arrow/adbc/driver/jni/SqlServerIntegrationTest.java Adds coverage for opening a DB via the new fluent API.
java/driver/jni-validation/src/test/java/org/apache/arrow/adbc/driver/jni/PostgresIntegrationTest.java Switches test setup to the fluent API and removes now-unused imports.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread java/driver/jni/src/main/java/org/apache/arrow/adbc/driver/jni/JniDriver.java Outdated
@lidavidm
lidavidm marked this pull request as ready for review July 1, 2026 06:16
@lidavidm
lidavidm requested review from amoeba and zeroshade July 1, 2026 06:16
@lidavidm
lidavidm merged commit 2bd8778 into apache:main Jul 2, 2026
21 checks passed
@lidavidm
lidavidm deleted the jni-builder branch July 2, 2026 22:55
@lidavidm lidavidm added this to the ADBC Libraries 24 milestone Jul 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants