feat(rust): make boolean conventions clearer - #4427
Merged
Merged
Conversation
abonander
commented
Jun 22, 2026
| //! Various option and configuration types. | ||
| use std::{os::raw::c_int, str::FromStr}; | ||
|
|
||
| use crate::constants::{ADBC_OPTION_VALUE_DISABLED, ADBC_OPTION_VALUE_ENABLED}; |
Contributor
Author
There was a problem hiding this comment.
I see other references to this module are qualified under constants:: but I felt that would have made the docs unnecessarily noisy.
abonander
force-pushed
the
ab/option-bool
branch
from
June 22, 2026 17:31
2411558 to
e2404af
Compare
abonander
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
From<bool> for OptionValueandTryFrom<OptionValue> for bool(andTryFrom<&OptionValue>).Documents boolean conventions on
OptionValuefor clarity/discoverability.closes #4413