Skip to content

fix(go/adbc/sqldriver): properly close resources #3731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zeroshade merged 3 commits into from
Nov 19, 2025
Merged

fix(go/adbc/sqldriver): properly close resources #3731

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eed1441
fix(go/adbc/sqldriver): properly close resources
zeroshade Nov 19, 2025
ebd93a3
oops
zeroshade Nov 19, 2025
fffe107
linting
zeroshade Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion go/adbc/sqldriver/driver.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,14 @@ func (c *connector) Connect(ctx context.Context) (driver.Conn, error) {
// mainly to maintain compatibility with the Driver method on sql.DB
func (c *connector) Driver() driver.Driver { return Driver{c.drv} }

// Close closes the underlying database handle that the connector was using.
//
// By implementing the io.Closer interface, sql.DB will correctly call
// Close on the connector when sql.DB.Close is called.
func (c *connector) Close() error {
return c.db.Close()
}

type Driver struct {
Driver adbc.Driver
}
Expand Down Expand Up @@ -638,8 +646,10 @@ func (r *rows) Close() error {

r.rdr.Release()
r.rdr = nil

err := r.stmt.Close()
r.stmt = nil
return nil
return err
}

func (r *rows) Next(dest []driver.Value) error {
Expand Down
Loading