Skip to content

fix(r/adbcdrivermanager): support replace and create_append ingest mode in write_adbc() #3476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paleolimbot merged 2 commits into from
Sep 25, 2025
Merged

fix(r/adbcdrivermanager): support replace and create_append ingest mode in write_adbc() #3476

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f128c73
feat(r/adbcdrivermanager): support `replace` and `create_append` inge…
eitsupi Sep 24, 2025
ccc3c51
test(r/adbcsqlite): add test for the new feature
eitsupi Sep 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions r/adbcdrivermanager/R/helpers.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,9 @@
#' @param tbl A data.frame, [nanoarrow_array][nanoarrow::as_nanoarrow_array],
#' or [nanoarrow_array_stream][nanoarrow::as_nanoarrow_array_stream].
#' @param target_table A target table name to which `tbl` should be written.
#' @param mode One of "create", "append", or "default" (error if the schema
#' is not compatible or append otherwise).
#' @param mode One of `"create"`, `"append"`, `"replace"`, `"create_append"` (error if the schema
#' is not compatible or append otherwise), or `"default"` (use the `adbc.ingest.mode`
#' argument of [adbc_statement_init()]). The default is `"default"`.
#' @param query An SQL query
#' @param bind A data.frame, nanoarrow_array, or nanoarrow_array_stream of
#' bind parameters or NULL to skip the bind/prepare step.
Expand Down Expand Up @@ -67,7 +68,7 @@ execute_adbc <- function(db_or_con, query, ..., bind = NULL) {
#' @rdname read_adbc
#' @export
write_adbc <- function(tbl, db_or_con, target_table, ...,
mode = c("default", "create", "append"),
mode = c("default", "create", "append", "replace", "create_append"),
temporary = FALSE) {
UseMethod("write_adbc", db_or_con)
}
Expand Down Expand Up @@ -111,7 +112,7 @@ execute_adbc.default <- function(db_or_con, query, ..., bind = NULL, stream = NU

#' @export
write_adbc.default <- function(tbl, db_or_con, target_table, ...,
mode = c("default", "create", "append"),
mode = c("default", "create", "append", "replace", "create_append"),
temporary = FALSE) {
assert_adbc(db_or_con, c("adbc_database", "adbc_connection"))
mode <- match.arg(mode)
Expand Down
7 changes: 4 additions & 3 deletions r/adbcdrivermanager/man/read_adbc.Rd
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

19 changes: 19 additions & 0 deletions r/adbcsqlite/tests/testthat/test-adbcsqlite-package.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,3 +125,22 @@ test_that("write_adbc() with temporary = TRUE works with sqlite databases", {
adbcdrivermanager::adbc_connection_release(con)
adbcdrivermanager::adbc_database_release(db)
})

test_that("write_adbc() supports mode replace/create_append", {
skip_if_not(packageVersion("adbcdrivermanager") >= "0.20.0.9000")

db <- adbc_database_init(adbcsqlite())
con <- adbc_connection_init(db)

df <- data.frame(x = as.double(1:10))

adbcdrivermanager::write_adbc(mtcars, con, "df")
adbcdrivermanager::write_adbc(df, con, "df", mode = "replace")

stream <- adbcdrivermanager::read_adbc(con, "SELECT * from df")
expect_identical(as.data.frame(stream), df)

adbcdrivermanager::write_adbc(df, con, "df", mode = "create_append")
stream <- adbcdrivermanager::read_adbc(con, "SELECT * from df")
expect_identical(as.data.frame(stream), rbind(df, df))
})
Loading