fix(go/adbc/pkg): Run make regenerate to keep generated code in sync with templates - #3202
Merged
Conversation
felipecrv
commented
Jul 25, 2025
| func FlightSQLDriverInit(version C.int, rawDriver *C.void, err *C.struct_AdbcError) C.AdbcStatusCode { | ||
| // For backwards compatibility | ||
| return AdbcDriverFlightsqlInit(version, rawDriver, err) | ||
| return AdbcDriverFlightSQLInit(version, rawDriver, err) |
Contributor
Author
There was a problem hiding this comment.
@zeroshade do I have to update mentions of the AdbcDriverFlightsqlInit string in other drivers?
$ git grep --name-only AdbcDriverFlightsqlInit
c/driver/flightsql/sqlite_flightsql_test.cc
c/include/arrow-adbc/driver/flightsql.h
c/integration/static_test/main.c
csharp/src/Drivers/Interop/FlightSql/FlightSqlDriverLoader.cs
Contributor
Author
There was a problem hiding this comment.
Well... C# interop tests tell me yes :)
Member
There was a problem hiding this comment.
yea, the generation should be fixed so that it doesn't change driver.go to AdbcDriverFlightSQLInit and keeps it as AdbcDriverFlightsqlInit which is what is failing.
Contributor
Author
There was a problem hiding this comment.
The 3 spellings of SQL:
SQLsqlSql
… generated function" This reverts commit 811763b.
…generated function
felipecrv
commented
Jul 25, 2025
| // For backwards compatibility | ||
| return AdbcDriverFlightsqlInit(version, driver, error); | ||
| } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
The changes to init.go were needed to compensate for this removal of code that was previously manually added to this auto-generated C file.
felipecrv
changed the title
felipecrv
changed the title
zeroshade
approved these changes
Jul 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.