docs: Is ADBC support in DuckDB still in progress?

[raulcd]

What would you like help with?

On the documentation we can see:

ADBC support in DuckDB is still in progress.  See `duckdb/duckdb#7141
<https://github.com/duckdb/duckdb/issues/7141>`_ for details.

but if we go to the duckdb issue it's closed and all tasks have been done, should we update the documentation? I am happy to update the docs but just wanted to understand whether there are still things unsupported to link to those.

[paleolimbot]

I believe we can say that it's "supported"...I seem to remember there are some rough edges but it's pretty much all the way there (even Substrait, I think).

[lidavidm]

I think we can just link to their documentation, yeah. If we want to go the extra mile we could write up some recipes for the documentation here too.

[zeroshade]

A while back I had contributed the examples shown in https://duckdb.org/docs/api/adbc to the DuckDB documentation. If we want, we could also add the same examples here?

[eitsupi]

I was wondering if there is a possibility that ADBC may not support API 1.1.0, since the DuckDB documentation¹ states the following.

DuckDB's ADBC driver currently supports version 0.7 of ADBC.

However, when I went through the history, it seems that the version written here is the library version (duckdb/duckdb#9185), and the API was already 1.1.0 at the time of the library 0.7.0 release².

So does this mean that DuckDB supports the latest ADBC API?
Perhaps the "0.7" notation is confusing and should be updated.

Footnotes

1. https://duckdb.org/docs/stable/clients/adbc.html ↩

2. https://arrow.apache.org/blog/2023/09/23/adbc-0.7.0-release/ ↩

[lidavidm]

Hmm...I think they must've written "DuckDB 0.7.0 supports ADBC" wrongly

[eitsupi]

I think they must've written "DuckDB 0.7.0 supports ADBC" wrongly

This document was updated at the time of the DuckDB 0.10.0 release, so I believe they are referring to the ADBC version number and are not mistaken (duckdb/duckdb-web#2203).

[lidavidm]

Hmm, but there never was an 'ADBC 0.7.0'.

[eitsupi]

Hmm, but there never was an 'ADBC 0.7.0'.

The title seems to be saying 0.7.0 because the test started failing with the release of Python's adbc_driver_manager package 0.7.0 (duckdb/duckdb#9068) and the PR fixed that.

[CurtHagenlocher]

FWIW, DuckDb supports only the 1.0.0 version of the ADBC spec and not the 1.1.0 version.

[eitsupi]

FWIW, DuckDb supports only the 1.0.0 version of the ADBC spec and not the 1.1.0 version.

Thanks for pointing that out!
I thought 1.1.0 was supported because the source code looked like there was something was added in 1.1.0, but is that actually not the case?

[CurtHagenlocher]

I thought 1.1.0 was supported because the source code looked like there was something was added in 1.1.0, but is that actually not the case?

If you look at the source (i.e. https://github.com/duckdb/duckdb/blob/894822942c1859bac9b0f7cd10fea62e7ba23a47/src/common/adbc/adbc.cpp) you'll see that they only set the function pointers for functions in the 1.0.0 API. (They also don't check the requested version being passed in :(.)

[eitsupi]

I've recently been working on DuckDB's ADBC ​​1.1.0 support.

• The info key ADBC_INFO_DRIVER_ADBC_VERSION (feat(adbc): support ADBC_INFO_DRIVER_ADBC_VERSION (new in ADBC 1.1.0) duckdb/duckdb#20344)
• The canonical option "uri" (feat(adbc): support the uri option of ADBC 1.1.0 duckdb/duckdb#20312)
• Cancellation (feat(adbc): implement cancellation of ADBC 1.1.0 duckdb/duckdb#20511)
• The ability to both get and set options of different types (feat(adbc): implement ADBC 1.1.0 typed option API and remaining canonical options duckdb/duckdb#20924)
• Bulk Ingestion supports two additional modes (feat(adbc): partial supporting ADBC 1.1.0 duckdb/duckdb#19833)
• Rich Error Metadata (fix(adbc): implement ADBC 1.1.0 Rich Error Metadata API duckdb/duckdb#23073)
• table/column statistics (fix(adbc): support the ADBC Statistics API duckdb/duckdb#23230)