Repository navigation
Conversation
Cover python_kubernetes_script.py (remove_task_decorator, _balance_parens, write_python_script) and utils/delete_from.py (API class derivation, kind conversion, namespace precedence, List fanout, FailToDeleteError) with unit tests using mocked kubernetes.client classes. Remove both entries from the OVERLOOKED_TESTS allowlist now that dedicated test modules exist.
RyukR1
requested review from
hussein-awala,
jedcunningham and
jscheffl
as code owners
October 10, 2026 02:50
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add dedicated test modules for two untested
cncf.kubernetesprovider modulesand remove them from the
OVERLOOKED_TESTSallowlist.test_python_kubernetes_script.py(21 tests) covers:_balance_parens— simple, nested, deeply nested, and empty parenthesesremove_task_decorator— no-args, with-args, nested-parens,@setup/@teardownstripping, absent decorator, multiline args, and a test pinning the closure-scope behaviourwrite_python_script— template rendering to file,NativeEnvironmentselection,StrictUndefinedraising on missing variablestest_delete_from.py(24 tests) covers:apiVersion(core group, named group,.k8s.iostripping, DNS subdomain → CamelCase)Listkind fanout withapiVersioninheritanceApiExceptioncollection intoFailToDeleteErrorand__str__formattingAll tests use mocked
kubernetes.clientAPI classes — no cluster required.closes: Add missing tests for
cncf.kubernetesscript and delete utilities #72265Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.