Skip to content

Add missing tests for cncf.kubernetes script and delete utilities - #74524

Open
RyukR1 wants to merge 1 commit into
apache:mainfrom
RyukR1:add-k8s-script-delete-tests
Open

RyukR1 wants to merge 1 commit into
apache:mainfrom
RyukR1:add-k8s-script-delete-tests

Conversation

@RyukR1

@RyukR1 RyukR1 commented Oct 10, 2026

Copy link
Copy Markdown
Contributor

Add dedicated test modules for two untested cncf.kubernetes provider modules
and remove them from the OVERLOOKED_TESTS allowlist.
test_python_kubernetes_script.py (21 tests) covers:

  • _balance_parens — simple, nested, deeply nested, and empty parentheses
  • remove_task_decorator — no-args, with-args, nested-parens, @setup/@teardown stripping, absent decorator, multiline args, and a test pinning the closure-scope behaviour
  • write_python_script — template rendering to file, NativeEnvironment selection, StrictUndefined raising on missing variables
    test_delete_from.py (24 tests) covers:
  • API class name derivation from apiVersion (core group, named group, .k8s.io stripping, DNS subdomain → CamelCase)
  • Kind CamelCase → snake_case conversion
  • Namespaced vs non-namespaced dispatch and namespace precedence
  • Default deletion body
  • List kind fanout with apiVersion inheritance
  • ApiException collection into FailToDeleteError and __str__ formatting
    All tests use mocked kubernetes.client API classes — no cluster required.
    closes: Add missing tests for cncf.kubernetes script and delete utilities #72265

Was generative AI tooling used to co-author this PR?
  • Yes — Gemini 3.1 Pro (High)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

Cover python_kubernetes_script.py (remove_task_decorator, _balance_parens,
write_python_script) and utils/delete_from.py (API class derivation, kind
conversion, namespace precedence, List fanout, FailToDeleteError) with
unit tests using mocked kubernetes.client classes.

Remove both entries from the OVERLOOKED_TESTS allowlist now that dedicated
test modules exist.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:cncf-kubernetes Kubernetes (k8s) provider related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add missing tests for cncf.kubernetes script and delete utilities

1 participant