fix(plugin-dev): prevent validate-agent.sh exiting on first warning - #84427
Open
erichanwang wants to merge 1 commit into
Open
fix(plugin-dev): prevent validate-agent.sh exiting on first warning#84427erichanwang wants to merge 1 commit into
erichanwang wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016A6KkbNjaUq7QKa99jAcfW
This was referenced Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #76985.
Prevent
validate-agent.shfrom terminating after the first warning or error when running underset -e.Problem
The validator increments counters using:
In Bash these expressions return a non-zero exit status when the previous value is zero, which can trigger
errexitand stop validation before the remaining checks and summary are reached.PR #76985 intentionally left this issue out of scope.
Changes
Replace postfix increments with:
This preserves the counter values while allowing validation to continue through all validation checks.
Verification
bash -n plugins/plugin-dev/skills/agent-development/scripts/validate-agent.shgit diff --checkScope
This PR only changes counter increments to avoid unintended
errexitbehavior. No validation rules or output were modified.🤖 Generated with Claude Code
https://claude.ai/code/session_016A6KkbNjaUq7QKa99jAcfW