fix(scripts): allow any user to prevent auto-close with thumbs down - #84365
Open
alifakbxr wants to merge 2 commits into
Open
fix(scripts): allow any user to prevent auto-close with thumbs down#84365alifakbxr wants to merge 2 commits into
alifakbxr wants to merge 2 commits into
Conversation
This fixes a vulnerability where an exception (such as an ImportError or a generic exception during rule evaluation) would cause the hook to exit with status 0 and allow the gated tool execution. Now, exceptions will emit a permissionDecision: 'deny', ensuring unauthorized actions are prevented when the hook fails. Resolves anthropics#84302
Fixes anthropics#79146. The dedupe bot promises 'To prevent auto-closure, add a comment or 👎 this comment', but the logic only checked if the issue author thumbs-downed. Since anyone commenting already prevents closure, anyone thumbs-downing should as well, matching the comment's wording and intent.
This was referenced Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #79146. Matches the dedupe bot's promise by allowing any user's thumbs down to prevent closure.