fix(plugin-dev): limit frontmatter parsing - #84004
Open
RerankerGuo wants to merge 1 commit into
Open
Conversation
This was referenced Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
The range-based
sedexpression restarts at every later---line. If a settings file's Markdown body contains horizontal rules, text between those rules is appended toFRONTMATTER. A body line such asenabled: falsecan then produce a second value for a field that is already defined in the actual frontmatter.Verification
Using a settings fixture with
enabled: truein the opening frontmatter andenabled: falsebetween two body horizontal rules:enabledprints bothtrueandfalseenabledprints onlytrue---return 1 withNo frontmatter foundbash -n plugins/plugin-dev/skills/plugin-settings/scripts/parse-frontmatter.shgit diff --checkScope
This preserves the existing simple
key: valuefield parsing. It only corrects which section of the file is treated as frontmatter.