fix(scripts): validate gh flag values - #83999
Open
RerankerGuo wants to merge 1 commit into
Open
Conversation
Track value-taking flags while parsing wrapper arguments and fail with an actionable error instead of forwarding an incomplete command to gh.
This was referenced Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reject value-taking flags that are missing their value in the restricted
ghwrapper.The parser previously left
skip_next=trueat end of input and forwarded incomplete commands such asgh issue list --limit. This bypassed the wrapper's argument validation and delegated the failure togh.Changes
ghif input ends while a value is pending.Verification
--state,--limit, and--labelvalues each exit 1 before theghshim is called.issue list --state open --limit 20preserves its original argv.search issues bug --label=bug --limit=10preserves--flag=valuearguments.issue view 123 --commentsremains valid.bash -n scripts/gh.sh.git diff --check.Scope
This PR only validates flags that require values. It does not change the allowed command or flag set.