Skip to content

feat(tui): click on subagents to open them - #5761

Merged
rekram1-node merged 4 commits into
anomalyco:devfrom
rgodha24:subagent-ux
Dec 19, 2025
Merged

rekram1-node merged 4 commits into
anomalyco:devfrom
rgodha24:subagent-ux

Conversation

@rgodha24

Copy link
Copy Markdown
Contributor
Screen.Recording.2025-12-18.at.2.00.49.PM.mov

the latency is just because im doing this over an ssh connection

Copilot AI review requested due to automatic review settings December 18, 2025 21:01

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds interactive click functionality to subagent task displays in the TUI, allowing users to click on subagent tasks to open them in a dialog with navigation options.

  • Converts TaskTool rendering to an interactive clickable box with hover effects
  • Adds a new dialog component for subagent actions (currently supporting "Open" action to navigate to the subagent's session)
  • Implements text selection detection to prevent dialog opening when users are selecting text

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
packages/opencode/src/cli/cmd/tui/routes/session/index.tsx Updated TaskTool registration to use an interactive box component with mouse event handlers, hover states, and dialog integration for subagent navigation
packages/opencode/src/cli/cmd/tui/routes/session/dialog-subagent.tsx New dialog component providing action menu for subagent sessions with navigation to the subagent's session view

The code changes follow established patterns in the codebase, implement appropriate null checks, and integrate cleanly with existing dialog and navigation systems. No issues were identified during the review.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@rgodha24 rgodha24 changed the title tui: click on subagents to open them feat(tui): click on subagents to open them Dec 18, 2025
@rekram1-node

Copy link
Copy Markdown
Collaborator

this is good

@rekram1-node

Copy link
Copy Markdown
Collaborator

/review

@github-actions

Copy link
Copy Markdown
Contributor

lgtm

@rekram1-node
rekram1-node merged commit 5f03290 into anomalyco:dev Dec 19, 2025
3 checks passed
shuv1337 added a commit to shuv1337/shuvcode that referenced this pull request Dec 19, 2025
* feat(tui): click on subagents to open them (anomalyco#5761)

Co-authored-by: Aiden Cline <63023139+rekram1-node@users.noreply.github.com>

* chore: generate

* fix: better api call error msgs in some cases

* tweak: better release notes (grouped changelog) (anomalyco#5768)

* ci: better err msg for generate workflow

* fix(desktop): extra reqs

* fix(desktop): shell mode

* release: v1.0.169

* sync: record last synced tag v1.0.169

---------

Co-authored-by: Rohan Godha <git@rohangodha.com>
Co-authored-by: Aiden Cline <63023139+rekram1-node@users.noreply.github.com>
Co-authored-by: GitHub Action <action@github.com>
Co-authored-by: Aiden Cline <aidenpcline@gmail.com>
Co-authored-by: Luke Parker <10430890+Hona@users.noreply.github.com>
Co-authored-by: Adam <2363879+adamdotdevin@users.noreply.github.com>
Co-authored-by: opencode <opencode@sst.dev>
Co-authored-by: opencode-agent[bot] <opencode-agent[bot]@users.noreply.github.com>
rekram1-node added a commit that referenced this pull request Dec 27, 2025
Co-authored-by: Aiden Cline <63023139+rekram1-node@users.noreply.github.com>
Rwanbt pushed a commit to Rwanbt/unifia that referenced this pull request May 5, 2026
Co-authored-by: Aiden Cline <63023139+rekram1-node@users.noreply.github.com>
AIALRA-0 pushed a commit to AIALRA-0/opencode-turn-engine that referenced this pull request Jun 10, 2026
Co-authored-by: Aiden Cline <63023139+rekram1-node@users.noreply.github.com>
Rwanbt pushed a commit to Rwanbt/unifia that referenced this pull request Jun 14, 2026
Co-authored-by: Aiden Cline <63023139+rekram1-node@users.noreply.github.com>
MarsQiu007 referenced this pull request in MarsQiu007/openNovel Jul 31, 2026
Co-authored-by: Aiden Cline <63023139+rekram1-node@users.noreply.github.com>
meSingh pushed a commit to meSingh/opencode that referenced this pull request Sep 6, 2026
Co-authored-by: Aiden Cline <63023139+rekram1-node@users.noreply.github.com>
androidand pushed a commit to androidand/opencode-skein that referenced this pull request Sep 19, 2026
Co-authored-by: Aiden Cline <63023139+rekram1-node@users.noreply.github.com>
16Coffee pushed a commit to 16Coffee/opencode-mitra that referenced this pull request Oct 16, 2026
有些服务一个端点多个主机,把规范资源声明在别的主机上(ElevenLabs:配置
api.elevenlabs.io/v1/mcp,声明 https://api.us.elevenlabs.io/v1/mcp)。SDK 的同源校验直接拒绝,
登录在打开浏览器之前就失败。

provider 实现 validateResourceURL:同源沿用 SDK 规则;跨主机时资源必须自证——双方 https、
路径相同、声明里不带凭据/查询/片段,资源主机自己的 RFC 9728 path 元数据(不跟随跳转)声明的
resource 与之完全一致(§3.3),并列出发现阶段选定的授权服务器(saveDiscoveryState 只记在内存)。

只放宽校验仍会让恶意服务声明别人的 API、拿到令牌后在每次请求里收走它。所以令牌记下受众
(mcp-auth.json 的 tokens.resource,旧文件兼容),带 Bearer 的请求只发往受众所在的主机,配置的
主机永远收不到令牌;不带 Bearer 的发现、换 token、注册请求不改道。

思路参考 openwork anomalyco#5761(上游用主机白名单),这里改成按 RFC 9728 自证 + 令牌只发受众。

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants