Skip to content

fix(ui): render formatting inside markdown link labels #54451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Hona merged 1 commit into from
Oct 11, 2026
Merged

fix(ui): render formatting inside markdown link labels #54451

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/ui/src/context/marked-base.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,10 @@ import { Marked } from "marked"
export function createMarkdownBase() {
return new Marked({
renderer: {
link({ href, title, text }) {
link({ href, title, tokens }) {
const titleAttr = title ? ` title="${title}"` : ""

return `<a href="${href}"${titleAttr} class="external-link" target="_blank" rel="noopener noreferrer">${text}</a>`
return `<a href="${href}"${titleAttr} class="external-link" target="_blank" rel="noopener noreferrer">${this.parser.parseInline(tokens)}</a>`
},
},
})
Expand Down
16 changes: 12 additions & 4 deletions packages/ui/src/context/marked-parser.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,18 @@ import { parseSmallMarkdown } from "./marked-base"

const parser = createMarkdownParser((code, language) => `<pre data-language="${language}">${code}</pre>`)

test("renders links with application attributes", async () => {
expect(await parser.parse("[OpenCode](https://opencode.ai)")).toBe(
'<p><a href="https://opencode.ai" class="external-link" target="_blank" rel="noopener noreferrer">OpenCode</a></p>\n',
)
test.each([
["OpenCode", "OpenCode"],
["**`#123`**", "<strong><code>#123</code></strong>"],
["*Review* ~~draft~~", "<em>Review</em> <del>draft</del>"],
["`<example>`", "<code>&lt;example&gt;</code>"],
["\\*literal\\*", "*literal*"],
])("renders link label %s with application attributes", async (label, html) => {
const markdown = `[${label}](https://opencode.ai)`
const expected = `<p><a href="https://opencode.ai" class="external-link" target="_blank" rel="noopener noreferrer">${html}</a></p>\n`

expect(await parser.parse(markdown)).toBe(expected)
expect(parseSmallMarkdown(markdown)).toBe(expected)
})

test("renders inline and block math", async () => {
Expand Down
Loading