Repository navigation
fix(app): fix side panel tab clipping and alignment - #53315
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tabs stop at the
+padding-inline-end: 12px. Sticky offsets respect scroll-container padding, so the sticky+stuck 12px before the clip edge and scrolled tabs showed in that gap.::afterpatch on the+covered the gap. When it did not paint, the selected tab showed after the+.+box owns the 12px, so its edge is the clip edge. The patch is gone, and the+no longer moves 8px when the strip scrolls to the end.flowchart LR subgraph Before A[tabs] --> B["+ (sticky)"] --> C["12px padding<br/>tabs show here"] --> D[clip edge] end subgraph After E[tabs] --> F["+ (sticky, owns 12px)"] --> G[clip edge] endTabs share the review toggle's row
+sat 2px below the toggle (0.5px when stacked).--tabs-bar-height(48px, or51pxwhen stacked) for the strip and the actions:+review.spec.tsnow also checks that the+is centered on the toggle.File icons keep their left edge
margin-inline-start: -2px, but the tab trigger clips at its edge (overflow: hidden), so the first 2px of every file icon was cut.