Repository navigation
Remove project api - #52244
Closed
ljluestc wants to merge 6 commits into
Closed
Remove project api#52244ljluestc wants to merge 6 commits into
ljluestc wants to merge 6 commits into
Conversation
Projects could not be removed through the API or UI. Add project.remove to the Project service and expose it as DELETE /project/:projectID; dependent rows are removed by the existing ON DELETE CASCADE foreign keys. Regenerate the SDK. Refs anomalyco#51197
Contributor
|
Hey! Your PR title Please update it to start with one of:
Where See CONTRIBUTING.md for details. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: |
Member
|
This branch has been upgraded to V2. We're no longer taking PRs for V1. If you think this is still relevant, please port it over and open it for V2. — from 𝕺𝖕𝖊𝖓𝕮𝖔𝖉𝖊 |
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Refs #51197 (API part only; no app UI yet)
Type of change
What does this PR do?
There was no way to remove a project: the API only had list and update. This adds
Project.removeand exposes it asDELETE /project/:projectID. It returns 404 for an unknown project.The
session,project_directory, permission and workspace tables already referenceprojectwithON DELETE CASCADE, so deleting the row is enough to clean up dependent data. Files on disk are not touched. I also regenerated the JS SDK.The "remove project" action in the app and clearing the client-side
recentlyClosedlist are not included; I can follow up with those.How did you verify your code works?
test/project/project.test.ts(remove an existing project, NotFoundError for a missing one)bun test test/project/project.test.ts -t "Project.remove"andbun typecheckfrompackages/opencodeScreenshots / recordings
N/A, no UI change.
Checklist