Repository navigation
fix(ci): recognize issue references on v2 PRs - #52101
Closed
opencode-agent[bot] wants to merge 1 commit into
Closed
opencode-agent[bot] wants to merge 1 commit into
opencode-agent[bot] wants to merge 1 commit into
Conversation
Member
|
This branch has been upgraded to V2. We're no longer taking PRs for V1. If you think this is still relevant, please port it over and open it for V2. — from 𝕺𝖕𝖊𝖓𝕮𝖔𝖉𝖊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Port the existing
v2issue-reference fallback from #43964 to thedevPR-standards workflow. GitHub'sclosingIssuesReferencescan be empty for PRs targeting a non-default branch, so aFixes #...reference in the PR description must also satisfy the issue check.This addresses the false
needs:issuelabel seen on #52006, which references #51997 in its description. Thepull_request_targetworkflow runs fromdev, where the fallback was missing.Validation
check-standardsworkflow script against mock GitHub responses:v2PR withFixes #51997, default-branch PR with a GraphQL-linked issue, and PR without an issue reference. Also covered plain#51997and a body without the template section.v2version, andgit diff --checkpasses.Requested by: @rekram1-node (Aiden via Slack)