Skip to content

fix(permission): require read and shell descriptions - #49400

Closed
shabeeth2 wants to merge 2 commits into
anomalyco:devfrom
shabeeth2:permission-reason
Closed

shabeeth2 wants to merge 2 commits into
anomalyco:devfrom
shabeeth2:permission-reason

Conversation

@shabeeth2

Copy link
Copy Markdown

Require a trimmed, nonblank description field for read and shell tool calls in the legacy and Core V2 schemas. The description is propagated to normal and external-directory permission requests. Missing or blank values fail validation before execution or permission prompting.

Changes

  • Added description validation to bash and read tool schemas in core
  • Propagated descriptions to permission prompts in the TUI
  • Updated tests and parameter snapshots
  • 24 files changed, 986 insertions, 177 deletions

Verification

  • Core read/bash tests: 31 passed
  • OpenCode read/shell tests: 111 passed
  • Parameter tests: 58 passed
  • TUI permission tests: 11 passed
  • Focused session prompt test: 1 passed
  • \git diff --check: passed

@github-actions github-actions Bot added needs:compliance This means the issue will auto-close after 2 hours. needs:issue labels Sep 16, 2026
@github-actions

Copy link
Copy Markdown
Contributor

This PR doesn't fully meet our contributing guidelines and PR template.

What needs to be fixed:

  • PR description is missing required template sections. Please use the PR template.

Please edit this PR description to address the above within 2 hours, or it will be automatically closed.

If you believe this was flagged incorrectly, please let a maintainer know.

@github-actions

Copy link
Copy Markdown
Contributor

Thanks for your contribution!

This PR doesn't have a linked issue. All PRs must reference an existing issue.

Please:

  1. Open an issue describing the bug/feature (if one doesn't exist)
  2. Add Fixes #<number> or Closes #<number> to this PR description

See CONTRIBUTING.md for details.

@github-actions

Copy link
Copy Markdown
Contributor

The following comment was made by an LLM, it may be inaccurate:

Based on my search, I found one potentially related PR:

#26419 - fix(opencode): make bash tool description parameter optional
#26419

This PR addresses the bash tool description parameter, while PR #49400 requires descriptions to be nonblank and trimmed. These are related changes to the same tool schema, though #26419 made descriptions optional while #49400 enforces them as required.

All other results are either the current PR itself (#49400) or unrelated PRs about different features (workflows, storage, authentication, etc.).

@github-actions

Copy link
Copy Markdown
Contributor

This pull request has been automatically closed because it was not updated to meet our contributing guidelines within the 2-hour window.

Feel free to open a new pull request that follows our guidelines.

@github-actions github-actions Bot removed the needs:compliance This means the issue will auto-close after 2 hours. label Sep 16, 2026
@github-actions github-actions Bot closed this Sep 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant