Repository navigation
fix(core): skip skill rescans for unrelated config changes - #47397
Closed
kitlangton wants to merge 1 commit into
Closed
kitlangton wants to merge 1 commit into
kitlangton wants to merge 1 commit into
Conversation
Contributor
|
Automated PR Cleanup Thank you for contributing to opencode. Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions. This PR was closed because it matched the following cleanup criteria:
PRs created within the last month are not affected by this cleanup. If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate. Thanks again for taking the time to contribute. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An unrelated config edit currently rebuilds the entire configured skill catalog. For example, changing only
shelltriggers another directory scan, remote skill index pull, watcher teardown/recreation, and skill reload even though the source list is unchanged.Compare the derived, deduplicated skill-source descriptors in order before refreshing on
config.updated, while still retaining the latest config entries. This preserves path expansion and later-source precedence. Source additions, removals, reordering, and URL changes still refresh; filesystem events still refresh unconditionally, including symlink retargeting and missing-directory creation. Unrelated config edits consequently no longer act as incidental remote skill index refreshes.Regression coverage counts actual filesystem scans (delegating to FSUtil), discovery calls, catalog reloads, and watcher subscriptions. Before the fix, the unrelated shell edit increased scans/pulls/reloads by one each; afterward all three remain unchanged. It also checks equivalent relative/absolute paths, duplicates, source ordering, replacement/removal, and skill edits after a source change.
Validation:
bun typecheckinpackages/corepasses; focused oxlint andgit diff --checkpass..husky/pre-pushhook with temporary Bun 1.4.1 (no global installation change): version check passed and all 33 typecheck tasks succeeded (25 cache hits, 8 executed), exit code 0. Turbo emitted sandbox IO warnings but no task failed. This closes the validation gate initially bypassed during push.This PR is independent of the skill plugin startup read/subscribe gap fix.