Repository navigation
Conversation
The prepared model request only carried generation values set by hooks or context, so a model's configured limit.output never reached the provider. On Bedrock the request was sent without inferenceConfig.maxTokens and the service applied a much lower implicit budget; with adaptive thinking the whole budget could be consumed by reasoning, truncating responses at 4,096 tokens despite limit.output=128000. Project maxTokens with explicit precedence: hook/context override, model defaults, route defaults, then resolved.limit.output.
github-actions
Bot
added
the
needs:compliance
Contributor
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
This pull request has been automatically closed because it was not updated to meet our contributing guidelines within the 2-hour window. Feel free to open a new pull request that follows our guidelines. |
github-actions
Bot
removed
the
needs:compliance
3 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #46595
Type of change
What does this PR do?
The prepared model request dropped
generationentirely unless a hook or context set one, so a model's configuredlimit.outputnever reached the provider. On Bedrock the Converse request went out withoutinferenceConfig.maxTokens, the service applied a much lower implicit budget, and with adaptive thinking enabled the whole budget could be consumed by reasoning — truncating turns at 4096 output tokens despitelimit.output: 128000.This projects
maxTokensinto the request with explicit precedence: hook/context override → model defaults → route defaults →resolved.limit.output. The Bedrock protocol already serializesgeneration.maxTokensasinferenceConfig.maxTokens; it just never received a value.How did you verify your code works?
session-model-request.test.ts; updated two existing expectations that assertedgenerationwas undefined.packages/coresuite green (4,104 tests; one unrelatedSubagentTooltimeout passes in isolation).http.requesthook now shows"inferenceConfig":{"maxTokens":128000}, and previously-truncating sessions respond normally.Screenshots / recordings
Captured request before the fix (sanitized): no
inferenceConfigkey. After:{"modelId":"global.anthropic.claude-fable-5","inferenceConfig":{"maxTokens":128000},"additionalModelRequestFields":{"thinking":{"type":"adaptive","display":"summarized"},"output_config":{"effort":"xhigh"}}}