Skip to content

fix(opencode): finish errored compaction summaries - #30836

Closed
ShamirSecret wants to merge 1 commit into
anomalyco:devfrom
ShamirSecret:fix/compaction-finish
Closed

ShamirSecret wants to merge 1 commit into
anomalyco:devfrom
ShamirSecret:fix/compaction-finish

Conversation

@ShamirSecret

@ShamirSecret ShamirSecret commented Jun 5, 2026 •

Copy link
Copy Markdown

Issue for this PR

Fixes #30806

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

Compaction can leave a summary assistant message with an error but no finish value. That makes the compaction marker look unfinished to later session replay/task discovery.

This PR gives compaction summaries a terminal finish value before returning:

  • errored summaries get finish: "error"
  • successful summaries without a finish get finish: "stop"

This is related to #30806's dangling compaction summary issue, but only covers the errored-summary path.

How did you verify your code works?

From packages/opencode:

bun test test/session/compaction.test.ts --test-name "marks summary message as errored on compact result|marks errored summary message as finished when processor stops|adds synthetic continue prompt"
bun test test/session/messages-pagination.test.ts
bun typecheck

Screenshots / recordings

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

@github-actions github-actions Bot added needs:compliance This means the issue will auto-close after 2 hours. and removed needs:compliance This means the issue will auto-close after 2 hours. labels Jun 5, 2026
@github-actions

github-actions Bot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Thanks for updating your PR! It now meets our contributing guidelines. 👍

@github-actions

github-actions Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Automated PR Cleanup

Thank you for contributing to opencode.

Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions.

This PR was closed because it matched the following cleanup criteria:

  • The PR was created more than 1 month ago
  • The PR had fewer than 2 positive reactions
  • Positive reactions are counted as thumbs-up, heart, celebration, or rocket reactions on the PR

PRs created within the last month are not affected by this cleanup.

If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate.

Thanks again for taking the time to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: Revert state not cleaned before compaction causes ghost messages; aborted compaction leaves dangling partial summary

1 participant