Repository navigation
Conversation
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Potential Duplicate Found:
Why it's related: Both PRs address the same issue (#7690) about fixing LSP server root detection for ESLint and TypeScript in monorepo setups. PR #7691 appears to be the original fix for the exact same problem - fixing ESLint and tsserver LSP root detection to use the package-specific directory instead of the monorepo root. |
This was referenced May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #7690
Type of change
What does this PR do?
In monorepo setups, LSP servers for JavaScript/TypeScript languages (TypeScript, ESLint, and Astro) were failing to start because the module resolution for
tsserverandeslintwas usingInstance.directory(the monorepo root) instead of the detected package root. This caused issues when TypeScript or ESLint were installed locally in individual packages rather than at the monorepo root. This is how biome is configured already and it works correctly.The fix updates the
Module.resolvecalls in thespawnfunctions for TypeScript, ESLint, and Astro LSP servers to use therootparameter (the package-specific directory) instead ofInstance.directory.This ensures LSP servers can properly detect and use locally installed dependencies in monorepo environments.
How did you verify your code works?
I tested the changes in a monorepo setup with multiple JavaScript/TypeScript packages, verifying that LSP servers now start correctly and resolve dependencies from the correct package directories.
Screenshots / recordings
-Checklist