Brand crash dialog, add crash trigger if debug

[mikehardy]

Purpose / Description

Previously I've been relying on a personal collection of
crash bugs to test the crash dialog, but that's a poor testing
experience - now we have an advanced preference area to just crash

During the ACRA upgrade #4893 some branding was already broken, and
the rest was lost, when I finally saw the dialog again with
fresh eyes on my son's tablet it was terrible so this puts the
icon and title where they belong

Fixes

No issue logged, just fixed it

Approach

This adds a beautiful icon and nice text

How Has This Been Tested?

I am getting better at UI things so I added an advanced preference to trigger crashes, in debug mode only. I tested the pref was disabled in release builds and then tested the crash - debug/release + pre/post images attached

It does add one Codacy warning because I throw RuntimeException in the trigger

Checklist

Please, go through these checks before submitting the PR.

• You have not changed whitespace unnecessarily (it makes diffs hard to read)
• You have a descriptive commit message with a short title (first line, max 50 chars).
• Your code follows the style of the project (e.g. never omit braces in if statements)
• You have commented your code, particularly in hard-to-understand areas
• You have performed a self-review of your own code

[mikehardy]

Travis CI is having some sort of non-code-related crashing going on. May have to restart all these PR builds some other time, they're working on my Travis and locally

[mikehardy]

Travis is fixed - I had to delete the caches on the PRs with weird errors and that resolved it. Unfortunately each of my last 3 PRs have Codacy problems (UI tests are long, a crash trigger is a raw exception, and API level guarding is a weird nested-if) but I did work hard to maintain quality and I look forward to seeing what you think. Sorry I'm bombing you but I'm fine with review as you have time, of course :-)

[timrae]

Can you add the preference programmatically instead of in XML to avoid confusion? And I don't want these strings to be translated so just hard code them in.

[mikehardy]

Definitely, good idea

[timrae]

Icon looks great btw :)

[mikehardy]

re-pushing now - it was good practice for my nascent android UI skills, but the PR is even smaller now. Re-tested on debug and release builds, pref is shown or not shown as expected.

[timrae]

I would have preferred the new preference and the icon to be in separate commits, but it's not a big deal... Looking good!