Refactor top-level navigation and add More tab - #1908
Merged
anilbeesetti merged 1 commit intoSep 8, 2026
Merged
Conversation
This was referenced Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the top-level navigation out of the scene decorator and into the app scaffold. Home, Playlists, Network, and the new More tab keep separate back stacks; the floating navigation bar and shared action button switch with the active tab, and wider windows use a navigation rail. Hide the bar on nested destinations and during media selection, and preserve the source branch's inset, spacing, and animation fixes.
More provides vault access and the system video picker. Network owns the stream URL form and connection creation UI. Playback history and trash are separate follow-up PRs. Remove the unused navigation-suite dependency now that its consumer is gone.
The existing playlist FAB test now exercises the action registered with the shared FAB host, matching the new ownership.
Validation:
./gradlew assembleDebug test ktlintCheck: pass, 171 local tests with zero failures/errors.ANDROID_SERIAL=emulator-5580 ./gradlew :feature:playlist:connectedDebugAndroidTest: 16/16 pass.Split from local
refactor-navat02c0f369; based on the dependency PR. Review this diff againstcodex/refactor-nav-dependencies.Stack / merge order: #1907 → #1908 → #1909 → #1910. Each child targets its preceding PR branch so GitHub shows only that step. Merge in this order; retarget/rebase the next child onto
mainafter its parent merges as needed.Screenshots — before and after Home:
More and Network:
Wide navigation rail: