[Bug]: 🚨 `main` branch fails to run instrumented tests

[SimonMarquis]

Is there an existing issue for this?

• I have searched the existing issues

Is there a StackOverflow question about this issue?

• I have searched StackOverflow

What happened?

https://github.com/android/nowinandroid/actions/runs/6893913811/job/18754556371#step:7:870

> Task :app:connectedDemoDebugAndroidTest
Starting 14 tests on test(AVD) - 8.0.0

com.google.samples.apps.nowinandroid.ui.NavigationTest > topLevelDestinations_showSettingsIcon[test(AVD) - 8.0.0] FAILED 
	java.lang.NoSuchMethodError: No static method layout$default(Landroidx/compose/ui/layout/MeasureScope;IILjava/util/Map;Lkotlin/jvm/functions/Function1;ILjava/lang/Object;)Landroidx/compose/ui/layout/MeasureResult; in class Landroidx/compose/ui/layout/MeasureScope; or its super classes (declaration of 'androidx.compose.ui.layout.MeasureScope' appears in /data/app/com.google.samples.apps.nowinandroid.demo.debug-bIGZ_x9GeXlhDoRTOeMxqg==/base.apk:classes10.dex)
	at androidx.compose.material3.adaptive.navigation.suite.NavigationSuiteScaffoldKt$NavigationSuiteScaffoldLayout$1$1.measure-3p2s80s(NavigationSuiteScaffold.kt:157)

Relevant logcat output

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

[SimonMarquis]

Edit: wrong assumption, see last message for the explanation.

This PR introduced an incompatibility between androidx.compose.material3 dependencies using the version 1.1.2 comming from androidx.compose:compose-bom:2023.10.01, and hardcoded 1.0.0-alpha01 version:

Compose dependencies should not use explicit versions, and instead always rely on BoM to ensure compatibility.

[SimonMarquis]

Edit: nevermind, these artifacts do not follow the expected versioning scheme of androidx.compose.material3...

A solution could be to update the versions to the same stable version 1.1.2, but this would mean we no longer necessarily follow the versioning of the BoM.

[SimonMarquis]

After digging a bit deeper, the issue initially comes from disabling the transitivity property of these two alpha dependencies:

nowinandroid/app/build.gradle.kts

Lines 119 to 124 in f365e8b

	implementation(libs.androidx.compose.material3.adaptive) {
	this.isTransitive = false
	}
	implementation(libs.androidx.compose.material3.adaptive.navigation.suite) {
	this.isTransitive = false
	}

This tells Gradle to ignore transitive dependencies.
Which means that, the specific dependencies requested by these two artifacts will be ignored.

Warning

Disabling transitive dependency resolution will likely require you to declare the necessary runtime dependencies in your build script which otherwise would have been resolved automatically. Not doing so might lead to runtime classpath issues.
https://docs.gradle.org/current/userguide/resolution_rules.html#sec:disabling_resolution_transitive_dependencies

For example: if we decode the stacktrace, we can see that the compile classpath did not match the runtime classpath and therefore we have a runtime exception:

java.lang.NoSuchMethodError: No static method layout$default(MeasureScope, Int, Int, Map, Function1, Int, Object): MeasureResult in class Landroidx/compose/ui/layout/MeasureScope

Indeed, the dependency androidx.compose.ui:ui-android was previously coming directly from androidx.compose:compose-bom:2023.10.01 → androidx.compose.ui:ui-android:1.5.4
But at the same time the new alpha dependencies were requesting androidx.compose.material3:material3-adaptive:1.0.0-alpha01 → androidx.compose.foundation:foundation:1.6.0-alpha08 → androidx.compose.ui:ui:1.6.0-alpha08
And this is were the runtime collision happens.

At the moment, the two solutions that I can see are:

• embrace the alpha versions everywhere (not recommended)
• revert the PR that introduced these dependencies

[lihenggui]

No PRs have run successfully due to this bug now.

[alexvanyo]

@mmoczkowski could you investigate after adding the isTranstive = false lines in #942?

[SimonMarquis]

Fixed by

• Revert "Merge pull request #942 from android/feature/navigation-suite… #1054