Conversation
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not complete and needs a lot of work and verification.
Adds an AWS KMS signing path so the Developer ID private key never has to live on the signing machine. The existing
--p12flow is untouched.What's in the branch:
--kms-keyand--kms-cert-chainflags onquill sign(andsign-and-notarize). URI scheme matches sigstore/cosign (awskms:///alias/...orawskms:///arn:...).quill csrsubcommand for enrolling a Developer ID cert against a KMS-resident keypair (Apple's normal CSR flow assumes the private key is local... with the key in KMS that path doesn't work).crypto.Signerimplementation pinned toRSASSA_PKCS1_V1_5_SHA_256. We explicitly do not usesigstore/sigstore/pkg/signature/kmsbecause it forces RSA-PSS, which Apple Developer ID CMS does not use.TestSign_KMSruns the existing trusted fixtures through an in-process fake KMS provider and asserts byte-identical CodeDirectory + CMS output to the P12 path. Passescodesign --verify..github/workflows/apple-e2e-kms.yaml+workflow_dispatch-only pipeline that signs quill itself with a real KMS key + real Developer ID cert and submits to Apple Notary. The only thing that proves Apple actually accepts what we produce.docs/hsm-signing.md: threat model, end-to-end walkthrough, IAM policy, troubleshooting.TODOs before the Apple E2E workflow can run (one-time, manual):
RSA_2048SIGN_VERIFYKMS key + alias (alias/quill-ci-signingor similar).kms:Sign+kms:GetPublicKeyon that key, OIDC trust scoped to this repo +main.quill csragainst the new key, submit to Apple Developer portal, assemblechain.pemfrom the issued cert + Apple intermediates.QUILL_KMS_KEY_URI,QUILL_KMS_CERT_CHAIN_PEM,AWS_KMS_SIGNING_ROLE_ARN,AWS_KMS_REGION.APPLE_NOTARY_ISSUER,APPLE_NOTARY_KEY_ID,APPLE_NOTARY_KEYsecrets reused as-is.Out of scope, follow-up issues:
gcpkms://) and Azure Key Vault (azurekms://) providers.Closes #759