Skip to content

arm64: dts: adi: sc598-som-ezkit: expand OSPI flash partitions - #3504

Open
pamolloy wants to merge 1 commit into
adsp-6.18.31-yfrom
adsp-6.18.31/philip/sc598-ezkit-spi-layout
Open

arm64: dts: adi: sc598-som-ezkit: expand OSPI flash partitions#3504
pamolloy wants to merge 1 commit into
adsp-6.18.31-yfrom
adsp-6.18.31/philip/sc598-ezkit-spi-layout

Conversation

@pamolloy

@pamolloy pamolloy commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

The OSPI kernel and rootfs partitions on the MX66LM1G45G (128 MB) were not updated when the SoM SPI flash partitions were resized in commit 4e662b5 ("arm64: dts: adi: sc598-som-revE: extend rootfs to fill flash"). This left the kernel allocation at 15 MB and the rootfs at 16 MB, wasting 96 MB of the 128 MB device.

Align the OSPI layout with the IS25LP01G on the SoM revE:

kernel: 0x100000 + 0x2000000 (15 MB -> 32 MB)
rootfs: 0x2100000 + 0x5f00000 (16 MB -> 95 MB, fills device)

Fixes: dfc678d ("arch: arm64: dts: Add SD card dts for the sc598 EZKIT")

@pamolloy
pamolloy requested a review from a team August 19, 2026 15:49
@pamolloy pamolloy self-assigned this Aug 19, 2026
@pamolloy pamolloy added this to ADSP Aug 19, 2026
@pamolloy pamolloy added the llm review Request a review from a LLM Reviewer label Aug 19, 2026
The OSPI kernel and rootfs partitions on the MX66LM1G45G (128 MB) were
not updated when the SoM SPI flash partitions were resized in
commit 4e662b5 ("arm64: dts: adi: sc598-som-revE: extend rootfs to
fill flash"). This left the kernel allocation at 15 MB and the rootfs at
16 MB, wasting 96 MB of the 128 MB device.

Align the OSPI layout with the IS25LP01G on the SoM revE:

  kernel: 0x100000 + 0x2000000  (15 MB -> 32 MB)
  rootfs: 0x2100000 + 0x5f00000 (16 MB -> 95 MB, fills device)

Fixes: dfc678d ("arch: arm64: dts: Add SD card dts for the sc598 EZKIT")
Signed-off-by: Philip Molloy <philip.molloy@analog.com>
@github-actions

Copy link
Copy Markdown
Contributor

LLM review

This series resizes the OSPI kernel/rootfs partitions on sc598-som-ezkit to use the full 128 MiB of the MX66LM1G45G flash.

run: 32272370595

e207423c6bc7 - expand OSPI flash partitions

Verified the change is correct: 0x40000 + 0xc0000 + 0x2000000 + 0x5f00000 = 0x8000000 (128 MiB) exactly, partitions are contiguous and non-overlapping, and the new layout matches byte-for-byte the already-merged IS25LP01G layout on sc598-som-revE.dtsi (fixed in 4e662b50bb87). The Fixes: tag (dfc678d524ab) correctly identifies the commit that introduced the original 15 MiB/16 MiB sizes for this file. No issues found.

CI warnings

No checkpatch or build warnings for this commit. Built sc598-som-ezkit.dtb (and siblings) with CONFIG_ARCH_SC59X_64 enabled; the only DTC warning present (unique_unit_address on /scb/syscon@31004600) was reproduced identically both before and after this commit, confirming it is pre-existing and unrelated. dt-schema (dtbs_check) reports no fixed-partitions issues.

Verification data

MX66LM1G45G (Macronix) and IS25LP01G (ISSI) are third-party parts not hosted on Analog Devices' datasheet mirror, so their density could not be confirmed via an ADI datasheet. Density (1 Gbit = 128 MiB) was instead cross-checked via the in-tree mxicy,mx66lm1g45 JEDEC SPI-NOR binding, the standard vendor part-numbering convention, and by decompiling the built .dtb to confirm the resulting partition table matches the already-merged, arithmetically-identical IS25LP01G layout on sc598-som-revE.dtsi.

Observation (out of scope)

arch/arm64/boot/dts/adi/sc598-htol.dts still carries the old, unfixed IS25LP01G rootfs partition size (0x5ef0000, 64 KiB short of filling the device) - the same issue previously fixed for sc598-som-revE.dtsi in 4e662b50bb87. This file is untouched by the current commit, so no fixup is suggested here, but it may be worth a follow-up.

Suggested patches

None. No issues were found that require a fixup for this commit.

Install instructions

The following one-liner installs the script if not present already:

curl -fSsL "https://raw.githubusercontent.com/analogdevicesinc/doctools/refs/heads/main/ci/scripts/apply-patches.sh"      -o ~/.local/bin/apply-patches.sh &&   grep -q "/apply-patches.sh" ~/.bashrc || echo "source ~/.local/bin/apply-patches.sh" >> $_ ; . $_

More information at AI Usage.

@pamolloy
pamolloy marked this pull request as ready for review August 19, 2026 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

llm review Request a review from a LLM Reviewer

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants