Repository navigation
Conversation
Useful when the mesh agent is managed by a separate MeshCentral, or when only the RMM agent should come off a machine. Without the switch the uninstall behaves as before. UninstallLogMode=overwrite so agents updated from older versions don't keep the old mesh uninstall entry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
/KEEPMESHswitch to the Windows uninstaller so the RMM agent can be removed without also removing the mesh agent:This helps when the mesh agent is managed by a separate MeshCentral server, or when only the RMM agent should come off a machine. It's the uninstall counterpart to
-nomesh(see also amidaware/tacticalrmm#2191). Without the switch, the uninstall does exactly what it does today. The agent and the server aren't changed.Notes:
-fulluninstalland the Mesh Agent folder removal moved from[UninstallRun]/[UninstallDelete]intoCurUninstallStepChanged. ACheck:on those sections is evaluated at install time, so it can't see the uninstaller's command line. I tested that variant and it still removed mesh with/KEEPMESH.UninstallLogMode=overwrite: Inno appends to the existing uninstall log on update. So without this, an agent updated from an older version keeps the oldmeshrmentry, and the mesh agent is still removed even with/KEEPMESH.{app}is already deleted as a whole, so nothing else depends on the appended entries.Tested on Windows 11 with Inno Setup 6.7.4. I used a copy of setup.iss with its own AppId, paths and process names (so it couldn't touch the real agent on the box), with stub exes standing in for tacticalrmm.exe and meshagent.exe:
/KEEPMESH/keepmesh/KEEPMESHX/KEEPMESH/KEEPMESH