You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
f"unknown epilogue {self.epilogue!r} (expected 'none' or 'gelu')"
)
A nicer "Kernel" abstraction that encodes (i) the function name (extern C), (ii) the argument specification expected (MLIR func.func signature), (iii) how to compile and link it in would be good at some point in the future. If we have to list every single activation function in every GEMV and GEMM kernel as a custom prologue/epilogue, it will get old quick.
We could probably reuse ChanneledUnaryOperator for this. Extract the kernel and its calling convention out of the ChanneledUnaryOperator. A single prologue=ChanneledUnaryOperator(...) would enode all the information needed -- no listing of all functions inside GEMV.
Thanks for pointing on this, since while I am trying to make things work- I skip deeper design review for now. This should be properly thought, after I finish with my current tasks- I'll definitely think on that.
Activity
atassis commentedon Sep 8, 2026
Thanks for pointing on this, since while I am trying to make things work- I skip deeper design review for now. This should be properly thought, after I finish with my current tasks- I'll definitely think on that.