Skip to content

fix(e2e): disambiguate Close Tab locator in subagent-child-navigation spec #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alltomatos merged 1 commit into from
Sep 12, 2026
Merged

fix(e2e): disambiguate Close Tab locator in subagent-child-navigation spec #204

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/app/e2e/regression/subagent-child-navigation.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,11 @@ test("shows the not found fallback when the viewed session is deleted", async ({
})

await expect(page.getByText("This session cannot be found")).toBeVisible()
await expect(page.getByRole("button", { name: "Close Tab" })).toBeVisible()
// The tab strip's own "Close tab" button is always present alongside this
// fallback's "Close Tab" action button; Playwright role-name matching is
// case-insensitive by default, so an exact match is required to avoid a
// strict-mode violation matching both.
await expect(page.getByRole("button", { name: "Close Tab", exact: true })).toBeVisible()
await expect(page.getByRole("heading", { name: taskDescription })).toHaveCount(0)
})

Expand Down
Loading