fix(db): synchronize reads of writing segment - #722
Merged
Conversation
richyreachy
approved these changes
Sep 7, 2026
YongqiYin
added a commit
to YongqiYin/zvec
that referenced
this pull request
Sep 8, 2026
Keep this branch's single-lock segment design and short-lived collection lock: upstream alibaba#722 holds write_mtx_ shared for the whole query, which starves the exclusive writer on glibc (measured 6250 -> 12 docs/s with 4 readers, reproduced 3/3 on pure upstream code). Port the two indexer accessor locks added by upstream alibaba#726 (get_vector_indexer / get_quant_vector_indexer) so the merged lock covers everything seg_col_mtx_ did. Verified on Linux and macOS: 224 / 222 tests green, upstream's stricter Optimize concurrency test passes 5/5, query transients are zero, and fetch throughput is ~17x upstream with the writer running at full speed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.