Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closing a
StunProtocolwhile a transaction is in flight leaves the transaction running: its retry timer keeps callingsend_stun()on the closed transport, and the awaitingrequest()only finishes once all retransmissions time out (~40 s with the defaults). In aiortc this shows up as errors logged afterRTCPeerConnection.close()when ICE checks were still in progress.This adds
Transaction.abort(), which cancels the retry timer and fails the transaction with a newTransactionAborted(aTransactionError, so existingexcept stun.TransactionErrorhandlers incheck_startkeep working).StunProtocol.connection_lost()aborts all pending transactions.Tests:
test_abort(no retransmission after abort, abort is idempotent) andtest_close_aborts_transactions(closing the protocol fails the pending request). Both fail without the change.