Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Files with timestamps outside the ZIP format's 1980–2107 range can abort both manual backups and the user-data backup performed before a self-update. Epoch-zero timestamps from package-registry files reproduce the lower-bound failure. Far-future timestamps also fail, and local timezone conversion can move a UTC boundary timestamp out of range.
Use
ZipFile(strict_timestamps=False)in both backup writers so ZIP entry timestamps are clamped by the standard library. The file contents, Unix permissions, and source timestamps remain unchanged. Manual-backup metadata keeps the original modification time.Related to #1904: this addresses the timestamp failure only. Directory scanning and backup inclusion/exclusion behavior are unchanged, so the separate scan-performance report remains open.
Validation
Against
readyat60c940fd03fdaf60993b70070e6ca7142718200b, Python 3.12.14:ready(71 passed, 2 failed) because the execution sandbox denies Unix sockets:test_self_update_manager_usr_backup_skips_runtime_socketstest_self_update_manager_cleans_transient_desktop_agent_stateFocused command:
The full repository suite and a live Docker self-update were not run. No dependency changes. AI-assisted implementation and review.