fix(asyncapi): promote nested pydantic to components/schemas - #2445
Merged
Conversation
|
|
Lancetnik
reviewed
Aug 12, 2025
|
|
||
| assert schema["channels"] == {}, schema["channels"] | ||
|
|
||
| def test_nested_models_in_one_of_should_be_in_schemas(self) -> None: |
Member
There was a problem hiding this comment.
The current problem is not publisher-specific. As well it is not specific for 3.0.0 AsyncAPI version
It should exists for subscribers as well for (or with descriminator probably)
@subscibrer
async def handler(body: Model1 | Model2): ... So, can you please add tests and fix for 3.0.0 and 2.6.0 versions both? And place them somewhere near test_pydantic_model_mixed_regular. Alse, please add a link to the original Issue as a test docstring
Lancetnik
approved these changes
Aug 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Promote nested Pydantic model definitions from message payloads (including oneOf cases) into components/schemas and replace inline schemas with $ref references. This resolves incorrect “inplace” embedding of nested models in generated AsyncAPI 3.0 documents.
Not sure if it is a good implementation, however tests are passing
Fixes #2443
Type of change
Checklist
just lintshows no errors)just test-coveragejust static-analysis