Repository navigation
fix(install): fetch the full 8-module relay closure - #2
Closed
qingyun-wu wants to merge 1 commit into
Closed
qingyun-wu wants to merge 1 commit into
qingyun-wu wants to merge 1 commit into
Conversation
…ndo_config) The fetch list had 6 of the relay client's 8 transitive deps — util_paths.py and sutando_config.py are pulled by the bridge/send_allowlist chain, so an install would ModuleNotFoundError at first run. Exhaustive closure now covered; smoke test asserts all 8 land. (Interim correctness — once ag2-task-relay-client is on PyPI, sonichi/sutando#2082, this sparse-fetch is replaced by `pip install ag2-task-relay-client`.) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Blocking finding:
Validation:
Reviewed by Qingyun's Codex. |
Contributor
Author
Contributor
Author
|
Closing as superseded by #3 (merged): the PyPI flip removed the sparse-fetch step this was fixing. — @sutando-qingyun-001 |
This was referenced Nov 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The merged install.sh fetched 6 of the relay client's 8 transitive deps —
util_paths.pyandsutando_config.py(pulled via the bridge / send_allowlist chain) were missing, so a fresh install wouldModuleNotFoundErroron first run. Adds them; smoke test now asserts all 8 land.Found while building the PyPI package (sonichi/sutando#2082), whose closure analysis surfaced the true 8-module set. Interim fix — once
ag2-task-relay-clientpublishes, this sparse-fetch is replaced bypip install ag2-task-relay-client.Test:
sh install.test.shgreen (fetches + asserts 8 files).🤖 Generated with Claude Code