Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

added Romanian locale#5836

Merged
jbalsas merged 4 commits into
adobe:masterfrom
micnic:master
Nov 12, 2013
Merged

added Romanian locale#5836
jbalsas merged 4 commits into
adobe:masterfrom
micnic:master

Conversation

@micnic

@micnic micnic commented Nov 3, 2013

Copy link
Copy Markdown
Contributor

Romanian locale

@marcelgerber

Copy link
Copy Markdown
Contributor

Do you know anybody here on github who could review this?

@micnic

micnic commented Nov 3, 2013

Copy link
Copy Markdown
Contributor Author

Unfortunately, I don't know anybody with authority who could review my Romanian translation, I am a native speaker of Romanian, and want to use Brackets in my native language.

@jbalsas

jbalsas commented Nov 3, 2013

Copy link
Copy Markdown
Contributor

Hey @micnic, we don't need anyone with authority, just some other native speaker that could go through your translation, review it and let us know. If you don't know about anyone, probably @couzteau will ask in the dev list to see if someone pops up.

Additionally, we'll need you to sign the CLA before we can accept your contributions. You can do that at http://dev.brackets.io/brackets-contributor-license-agreement.html

@micnic

micnic commented Nov 4, 2013

Copy link
Copy Markdown
Contributor Author

Signed, I will try to find some more native speakers today, hope will find a lot of them.

@sandulungu

Copy link
Copy Markdown

Hello, I reviewed the strings and they look good.

@cojocaru

cojocaru commented Nov 4, 2013

Copy link
Copy Markdown

Hi, great work, translations are fine.

@bumbu

bumbu commented Nov 4, 2013

Copy link
Copy Markdown

Checked. I have some minor remarks (I added few comments to commit) but overall it looks really good.

@micnic

micnic commented Nov 4, 2013

Copy link
Copy Markdown
Contributor Author

@bumbu Ceea ce tine de remarci, m-am condus in general de localizarea franceza, ma mai uit si mai modific daca trebuie, iar de niciunul vs nici un vezi aici: http://dexonline.ro/articol/Niciun_sau_nici_un%3F

@micnic

micnic commented Nov 4, 2013

Copy link
Copy Markdown
Contributor Author

Added some improvements after @bumbu 's remarks.

@unNene

unNene commented Nov 4, 2013

Copy link
Copy Markdown

Eu as pune o virgulă după Live Preview:

"LIVE_DEVELOPMENT_ERROR_MESSAGE" : "Pentru a lansa Live Preview, Google Chrome trebuie să fie relansat cu opțiunea de depanarea la distanță activată.

Doriți ca Google Chrome să fie relansat cu opțiunea de depanare la distanță activată?",

În rest pare ok la o verificare vizuală.

I'm native speaker and I verified translations. Everything is ok.

@ghost ghost assigned jbalsas Nov 4, 2013
@micnic

micnic commented Nov 5, 2013

Copy link
Copy Markdown
Contributor Author

@unNene , prima construcție trebuie să aibă un sens independent (să aibă un predicat) de ceea ce urmează după virgulă, dar aici e ceva de tipul: Pentru a cumpăra lapte trebuie să avem bani :D mai multe informații aici: http://www.scientia.ro/homo-humanus/44-dificultati-ale-limbii-romane/152-reguli-folosire-virgula.html

@jbalsas

jbalsas commented Nov 11, 2013

Copy link
Copy Markdown
Contributor

Hey @micnic, sorry this fell off my radar :S We're closing this sprint, so we'd like to land this if possible.

@bumbu @unNene Are we good to go with this?

@bumbu

bumbu commented Nov 12, 2013

Copy link
Copy Markdown

Yes, it is a good translation.

@micnic

micnic commented Nov 12, 2013

Copy link
Copy Markdown
Contributor Author

Hi @jbalsas, glad to hear this, I reviewed the files again and didn't find any typo or something wrong, we are good to go!

@jbalsas

jbalsas commented Nov 12, 2013

Copy link
Copy Markdown
Contributor

@bumbu Awesome!!

@micnic Thanks a lot for working on this! If you have time, a couple of extra strings landed in the last days 74dafa4 and the Serbian and Persian locale names. Feel free to submit a different PR for those.

@bumbu @unNene @romanroibu @cojocaru @sandulungu Thanks so much everyone for taking your time to review this!!

Merging

jbalsas added a commit that referenced this pull request Nov 12, 2013
@jbalsas jbalsas merged commit e46c426 into adobe:master Nov 12, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants